From cd0cff7e015eaa5e6a95c226a1d0005e79752c93 Mon Sep 17 00:00:00 2001 From: bailwillharr Date: Mon, 20 Mar 2023 20:58:12 +0000 Subject: [PATCH] Fix bugs for clang --- src/gfx_device_vulkan.cpp | 4 ++-- src/vulkan/device.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gfx_device_vulkan.cpp b/src/gfx_device_vulkan.cpp index 3628316..03fa36a 100644 --- a/src/gfx_device_vulkan.cpp +++ b/src/gfx_device_vulkan.cpp @@ -678,7 +678,7 @@ namespace engine { /* create a global descriptor pool */ std::vector poolSizes{}; - poolSizes.emplace_back(VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, 100u); // purposely low limit + poolSizes.push_back({ VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, 100u }); // purposely low limit VkDescriptorPoolCreateInfo descriptorPoolInfo{}; descriptorPoolInfo.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO; @@ -981,7 +981,7 @@ namespace engine { // flag to re-create the swapchain before next render pimpl->swapchainIsOutOfDate = true; } - else if (res != VK_SUCCESS) throw std::runtime_error("Failed to queue present!"); + else if (res != VK_SUCCESS) throw std::runtime_error("Failed to queue present! Code: " + std::to_string(res)); pimpl->FRAMECOUNT++; diff --git a/src/vulkan/device.cpp b/src/vulkan/device.cpp index 3becb77..701ef96 100644 --- a/src/vulkan/device.cpp +++ b/src/vulkan/device.cpp @@ -51,7 +51,7 @@ namespace engine { res = vkEnumerateDeviceExtensionProperties(physDev, nullptr, &extensionCount, availableExtensions.data()); assert(res == VK_SUCCESS); - for (const VkExtensionProperties& ext : availableExtensions) { + for ([[maybe_unused]] const VkExtensionProperties& ext : availableExtensions) { LOG_TRACE("extension: {}", ext.extensionName); }